-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5042] release translations #4126
Conversation
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 13644fd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
||
#: meinberlin/apps/budgeting/assets/BudgetingProposalListItem.jsx:12 | ||
msgid "modified on" | ||
msgstr "geändert am" | ||
msgstr "bearbeitet am" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which wording do we use in the other (Django) list? I couldn't find "modified on" and I think, we should use the same wording for both lists. I will merge anyway, but could you check that out, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabinammm Did you see my comment? Did you find out about the other wording?
@@ -1282,3 +1195,56 @@ msgid "More information can be found in the privacy policy of Vimeo under: " | |||
msgstr "" | |||
"Weitere Informationen finden Sie in der Datenschutzerklärung von Vimeo " | |||
"unter: " | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fuzzylogic2000 this is all the deletd ones :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phillimorland Yes, and there are even more in another commit. But @sabinammm is on it and will put them all back!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fuzzylogic2000 actually I checked translation PRs through November 2021 and this is the only commit with automatically removed translations that I am re-adding. Is there another one that I missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sabinammm In the other commit/PR, I posted on taiga, we did not loose any translations, but only changed all the strings that were added to the old ones?
commit 4ab744a#diff-2833e2202830b2667d27de3334567174802d8e78f0ce316657b743fdcf47d038
from #4055
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fuzzylogic2000 Oh, thanks for the repost :) The strings that were removed in that commit, are now coming from a4 and are all there in the current translation files. These are also all in js-files. I only found 1 string that was removed in the other commit that comes from an a4-jsx-file, and this was removed correctly, as this string no longer exists anywhere. So I think we are good to go at this time, right?
Translation task for US #5042 prepare release.
This also fixes #4096